Initial ACDD Tests #65
Conversation
An initial set of ACDD tests. Adapted from ioos/compliance_checker.
|
@abkfenris, thank you very much and we apologize for overlooking this. We are extremely busy at the moment, which is why |
|
@forman Glad to hear that We're still interested in implementing tests for ACDD and other conventions, but didn't want to go too far down the wrong track or sink a lot of effort into something that is no longer maintained. |
|
It is in active use in our company (for sure a few others), just maintenance slowed down recently. We'll be back! |
|
Great! When I went asking around the community many folks hadn't heard about it but were very interested. |
forman
left a comment
forman
left a comment
There was a problem hiding this comment.
That looks already very good. Great work! We are happy to take this on board.
To move forward, could you please also
- Describe in
CHANGES.mdwhat will we added - Adapt the rule documentation generator mkruleref.py to also convert the new rules into markdown docs.
- Run the converter to update docs/rule-ref.md
Note, I wont be able to support you until the 14.01.2026, therefore pls contact my colleague @clarasb.
|
Great, I'll work on getting those ready by the time you're back, and I may have some additional ACDD tests adapted as well. |
|
...and please add yourself to the list of authors in |
Adds documentation for ACDD tests, isodate to the dependencies, and updates the changes.
Looks like pip in tests isn’t ready for the newer `dependency-groups` for development tooling that uv prefers.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 99.46% 99.48% +0.02%
==========================================
Files 67 74 +7
Lines 2810 2927 +117
Branches 413 425 +12
==========================================
+ Hits 2795 2912 +117
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clarasb
left a comment
clarasb
left a comment
There was a problem hiding this comment.
Thanks @abkfenris ! That looks good to me.
Please consider
- the change suggestion,
- to fix the
reccomendedtypo, - and to add the
acddplugin to the Readme.
Then, let's wait for a final review from @forman.
Co-authored-by: Clara Backens <[email protected]>
3 participants
I wanted to share an early draft PR before implementing too many rules to make sure I'm on the right track.
The IOOS compliance checker has implemented their own tests for ACDD, CF, IOOS, and others, but have ended up with a much more complex and hard to adapt library in the process. There is interest in using XRLint to help simplify things, and make it easier to share work across the ecosystem. Along those lines an idea is to move tests/rules upstream if there is interest rather than keeping their own implementation.
I've converted many of the more general ACDD global attribute tests over here.